Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release PR] Fix VPN internal user testing issues #2665

Merged

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1206986434624665/f
Tech Design URL:
CC:

Description:

This PR cherry picks #2664 to the release branch.

Steps to test this PR:

  1. See Fix VPN internal user bugs #2664 for testing steps

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Task/Issue URL: https://app.asana.com/0/414235014887631/1206986434624665/f
Tech Design URL:
CC:

Description:

This PR fixes an issue where the VPN Thank You modal was interrupting the setup flow.
@samsymons samsymons requested a review from quanganhdo April 3, 2024 02:19
@samsymons samsymons merged commit 5b67fa4 into release/7.114.0 Apr 3, 2024
13 checks passed
@samsymons samsymons deleted the sam/release-pr-fix-vpn-internal-user-bug branch April 3, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants